[FFmpeg-devel] [PATCH] vf_pad: keep a reference to the output buffer.

Stefano Sabatini stefasab at gmail.com
Thu Mar 8 16:48:54 CET 2012


On date Thursday 2012-03-08 12:01:11 +0100, Nicolas George encoded:
> Le nonidi 19 ventôse, an CCXX, Stefano Sabatini a écrit :
> > On date Wednesday 2012-03-07 17:23:45 +0100, Nicolas George encoded:
> > > Once fixed, the end_frame function does exactly
> > > what the default does: remove it.
> > The text is pretty confusing, I'd say:
> 
> Indeed, I had not realized.
> 
> > Pass a picture reference to avfilter_start_frame, and remove this
> > reference by using the default end_frame function.
> > 
> > This allows the filter to keep a reference to the ouput picture in
> > case it is unreferenced by the following filter, as it happens with
> > the settb filter.
> 
> That was not what I meant, although it may be an useful explanation. What I
> meant was:
> 
> Once fixed, the end_frame function does exactly what
> avfilter_default_end_frame does; therefore, end_frame
> can be removed to let avfilter_default_end_frame work.

Sure, feel free to edit the comment and commit, thanks.
-- 
FFmpeg = Furious Fancy Marvellous Ponderous Evanescent Game


More information about the ffmpeg-devel mailing list