[FFmpeg-devel] [PATCH 10/11] SAMI demuxer and decoder.

[Clément Bœsch]

On Fri, Jun 29, 2012 at 08:09:54PM +0200, Clément Bœsch wrote:
> On Fri, Jun 29, 2012 at 05:23:46PM +0200, Michael Niedermayer wrote:
> > On Fri, Jun 22, 2012 at 10:44:05PM +0200, Clément Bœsch wrote:
> > > FIXME: bump minor in lavc & lavf
> > [...]
> > 
> > > +static int sami_paragraph_to_ass(AVCodecContext *avctx, const char *src)
> > > +{
> > > +    SAMIContext *sami = avctx->priv_data;
> > > +    int ret = 0;
> > > +    char *tag = NULL;
> > > +    char *dupsrc = av_strdup(src);
> > 
> > is src guranteed to be 0 terminated ?
> > 
> 
> Yes, because of the zeroed packet padding.
> 
> > also testing the code with zzuf would probably make sense if you
> > havnt yet ...
> > 
> 
> Mmh indeed. I just fixed an infinite loop, seems OK now after 10k tests.
> An extended usage of zzuf actually raised a few more issues elsewhere in
> the patchset I fixed locally. I think I'll make more use of it…
> 
> > otherwise LGTM 
> > 
> 
> I'll push soon, thank you.
> 

Patchset pushed.

Thank you everyone for the reviews.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120629/5af4802a/attachment.asc>