[FFmpeg-devel] [PATCH 10/11] SAMI demuxer and decoder.

[Michael Niedermayer]

On Fri, Jun 22, 2012 at 10:44:05PM +0200, Clément Bœsch wrote:
> FIXME: bump minor in lavc & lavf
[...]

> +static int sami_paragraph_to_ass(AVCodecContext *avctx, const char *src)
> +{
> +    SAMIContext *sami = avctx->priv_data;
> +    int ret = 0;
> +    char *tag = NULL;
> +    char *dupsrc = av_strdup(src);

is src guranteed to be 0 terminated ?

also testing the code with zzuf would probably make sense if you
havnt yet ...

otherwise LGTM 

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120629/898dd112/attachment.asc>