[FFmpeg-devel] [PATCH 2/2] image2: Add "start_number" private option to the demuxer

[Michael Niedermayer]

On Sun, Jun 24, 2012 at 12:12:30AM +0600, Mashiat Sarker Shakkhar wrote:
> On 6/24/2012 12:04 AM, Michael Niedermayer wrote:
> >On Sat, Jun 23, 2012 at 10:11:50AM +0600, Mashiat Sarker Shakkhar wrote:
> >>Currently if a pattern is given we search for up to the fifth file name in
> >>that sequence. This option sets that limit to an arbitrary number.
> >[...]
> >>@@ -375,6 +376,7 @@ static const AVOption options[] = {
> >>      { "video_size",   "", OFFSET(video_size),   AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, DEC },
> >>      { "framerate",    "", OFFSET(framerate),    AV_OPT_TYPE_STRING, {.str = "25"}, 0, 0, DEC },
> >>      { "loop",         "", OFFSET(loop),         AV_OPT_TYPE_INT,    {.dbl = 0},    0, 1, DEC },
> >>+    { "start_number", "first number in the sequence", OFFSET(start_number), AV_OPT_TYPE_INT, {.dbl = 1}, 1, INT_MAX, DEC },
> >>      { NULL },
> >
> >I think this should be called max_start_number
> >
> >otherwise the patch LGTM
> 
> I can do that, but then the symmetry between muxer and demuxer will
> be lost. Do you insist on this change?

if you want to keep the name and symmetry, then he code could be
changed so it really starts at this number.
This would also make sense in case there are files from 3...100
but one would want to just read from, 15 to 100. Or if the first
number is very large it would then avoid trying to read millions of
files (which could be slow)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120623/9bf56686/attachment.asc>