[FFmpeg-devel] [PATCH] showwaves: fix PTS computation.

Nicolas George nicolas.george at normalesup.org
Sat Jun 23 15:11:11 CEST 2012


Le sextidi 6 messidor, an CCXX, Stefano Sabatini a écrit :
> Should be OK, considering that for this filter 1/inlink->sample_rate =
> outlink->time_base maybe this can be simplified to:
> insamples->pts + (p - (int16_t *)insamples->data[0]) / nb_channels;

I do not think it is guaranteed: if your input comes from ALSA, for example,
inlink->time_base = outlink->time_base = 1E-6 != 1/sample_rate.

Therefore I shall push at is, along with the other fix. Thanks for the
review.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120623/13d18acd/attachment.asc>


More information about the ffmpeg-devel mailing list