[FFmpeg-devel] [PATCH 04/11] lavf/microdvd: rewrite using subtitles queue API.

[Clément Bœsch]

On Sat, Jun 23, 2012 at 01:07:43PM +0200, Nicolas George wrote:
[...]
> > +        sub = ff_subtitles_queue_insert(&microdvd->q, line, len, 0);
> > +        if (!sub)
> > +            return AVERROR(ENOMEM);
> > +        sub->pos = pos;
> > +        sub->pts = get_pts(sub->data);
> > +        sub->duration = get_duration(sub->data);
> 
> There is a discussion about the correct field to store the duration of the
> subtitles (with the risk that the 32-bits duration field may be too small).
> 
> The same applies probably to other patches in this series.
> 

I can understand the concern for the duration of the whole presentation
(which I do not set, right), but for a single event I'm a bit sceptical.
Also, if we decide to use a 64-bit field for the even duration, it will
require changing a few others things, like the prototype of
ff_ass_add_rect().

Do you think it should be changed before this patchset?

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120623/b4d30de3/attachment.asc>