[FFmpeg-devel] [PATCH 5/9] lavfi/avcodec: deprecate avfilter_fill_frame_from_*_buffer_ref API

Stefano Sabatini stefasab at gmail.com
Sat Jun 23 13:46:04 CEST 2012


On date Saturday 2012-06-23 10:37:18 +0200, Clément Bœsch encoded:
> On Fri, Jun 22, 2012 at 12:11:19PM +0200, Stefano Sabatini wrote:
> > Deprecate functions:
> > avfilter_fill_frame_from_buffer_ref
> > avfilter_fill_frame_from_audio_buffer_ref
> > avfilter_fill_frame_from_video_buffer_ref
> > 
> > and schedule to drop them at the next API major bump.
> > 
> > The function avfilter_copy_buf_props() should be used instead.
> > ---
> >  ffplay.c              |    2 +-
> >  libavfilter/avcodec.c |    2 ++
> >  libavfilter/avcodec.h |    9 +++++++++
> >  libavfilter/version.h |    3 +++
> >  4 files changed, 15 insertions(+), 1 deletions(-)
> > 
> > diff --git a/ffplay.c b/ffplay.c
> > index 55c7825..5421968 100644
> > --- a/ffplay.c
> > +++ b/ffplay.c
> > @@ -1732,7 +1732,7 @@ static int video_thread(void *arg)
> >              if (fabs(is->frame_last_filter_delay) > AV_NOSYNC_THRESHOLD / 10.0)
> >                  is->frame_last_filter_delay = 0;
> >  
> > -            avfilter_fill_frame_from_video_buffer_ref(frame, picref);
> > +            avfilter_copy_buf_props(frame, picref);
> >  
> >              pts_int = picref->pts;
> >              tb      = filt_out->inputs[0]->time_base;
> 
> Don't you need to update ffmpeg.c as well?
> 
> ffmpeg.c: avfilter_fill_frame_from_video_buffer_ref(filtered_frame, picref);

Yes, it was already locally fixed.

[...]
> > diff --git a/libavfilter/avcodec.h b/libavfilter/avcodec.h
> > index 9636cfd..36ee4eb 100644
> > --- a/libavfilter/avcodec.h
> > +++ b/libavfilter/avcodec.h
> > @@ -48,6 +48,7 @@ int avfilter_copy_frame_props(AVFilterBufferRef *dst, const AVFrame *src);
> >   */
> >  int avfilter_copy_buf_props(AVFrame *dst, const AVFilterBufferRef *src);
> >  
> > +
> 
> Looks unrelated but it shouldn't hurt if you want it.

Doh fixed.

[...]
> > diff --git a/libavfilter/version.h b/libavfilter/version.h
> > index 221a0de..32426f4 100644
> > --- a/libavfilter/version.h
> > +++ b/libavfilter/version.h
> > @@ -68,5 +68,8 @@
> >  #ifndef FF_API_FOO_COUNT
> >  #define FF_API_FOO_COUNT                    (LIBAVFILTER_VERSION_MAJOR < 4)
> 
> Note: why is this < 4 (and not < 3)?

Dunno, but considering that quatar is going to bump major again I
could consider to leave the functions for another bump.

Opinions? Michael?
-- 
FFmpeg = Fancy and Freak Multipurpose Plastic Easy Guru


More information about the ffmpeg-devel mailing list