[FFmpeg-devel] [PATCH 3/3] two functions were declaredinlinebutwere referenced elsewhere

[Michael Niedermayer]

On Sat, Jun 16, 2012 at 12:40:40AM +0200, J. Bohl wrote:
> Hi,
> 
> I apologize for the inconvenience. I am on the verge of giving up, and
> do not want to cause more trouble.

its not really causing troubble, the code we have is strictly speaking
not correct even if all currently supported compilers handle it.


> OK, one last attempt: obviously icc (Linux) uses pre-4.3-GCC sematic,
> whereas icl (Windows) uses C99 sematic. So we would have to distinguish
> between icl and icc, and one way to do it is using the predefined macro
> __ICL versus __ICC (just verified that, __ICL is _not_ defined with icc
> and vice versa). 
> So, we have
> 
> #if defined(__ICL) ||  defined(__GNUC_STDC_INLINE__)

are all versions of ICL compatible with the C99 syntax ?
if not this maybe needs a version number check

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120616/21ed60e4/attachment.asc>