[FFmpeg-devel] [PATCH] libavfilter: added atempo filter

[Michael Bradshaw]

On Tue, Jun 5, 2012 at 10:41 PM,  <pkoshevoy at gmail.com> wrote:
> @@ -0,0 +1,1274 @@
> +/*
> + * Copyright (c) 2012 Pavel Koshevoy
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */

If you want, you can put your email after your name so you can be
contacted if necessary. License looks fine, but I just want to double
check you did indeed intend to use LGPL and not MIT/BSD-style license
(which you previously expressed a desire to do).

> +    for (int i = i0; i < i1; i++, xc++) {
> +
> +        FFTSample metric = xc->re;

While I don't have a significant preference either way, is there a
particular reason some if/for/while lines are followed by a blank
line, and others are not?

Thanks,

Michael