[FFmpeg-devel] [PATCH 1/5] bprint: add av_bprint_init_for_buffer().

Nicolas George nicolas.george at normalesup.org
Tue Jun 5 13:51:19 CEST 2012


L'octidi 18 prairial, an CCXX, Stefano Sabatini a écrit :
> I find the "for a pre-existing buffer" expression confusing, indeed I
> couldn't tell what it means without peeking at the code.
> Maybe more clear:
> using a pre-existing buffer
> 
> Also tell that "size" specifies the passed buffer size in bytes.

Changed the doxy into:

/**
 * Init a print buffer using a pre-existing buffer.
 *
 * The buffer will not be reallocated.
 *
 * @param buf     buffer structure to init
 * @param buffer  byte buffer to use for the string data
 * @param size    size of buffer
 */

> Same for name, maybe for_buffer -> use_buffer, but I'm not strong on
> this.

I find for_buffer more intuitive wrt my vision of how it works.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120605/97108588/attachment.asc>


More information about the ffmpeg-devel mailing list