[FFmpeg-devel] [PATCH 2/3] movenc: Handle need for extra packets to express subtitle duration.

[Philip Langdale]

On Sun, 29 Jul 2012 12:01:39 +0200
Clément Bœsch <ubitux at gmail.com> wrote:

> 
> > +         * dts == 0, which is rarely true for subtitles. So, as
> > soon
> 
> I'm not sure that's rarely true; I have 5 SRT at 00:00:00.000 in my
> collection. Of course the text is not part of the movie (various
> credits, disclaimer etc). Will they be remuxed?
> 

They will. The code only inserts the t=0 sample when it sees another
sample with t>0. If we assume dts is properly ordered, then it's safe
and the sample will be remuxed correctly.

> > +        for (int i = 0; i < mov->nb_streams; i++) {
> 
> Please move the int outside the for; it seems we are still undecided
> about that syntax so better keep it consistent with the rest of the
> code.

Will do.

Thanks,

--phil