[FFmpeg-devel] Fw: PATCH AC3 audio issue is Fixed for Blu-ray Players.

[Michael Niedermayer]

On Fri, Jul 27, 2012 at 03:00:07PM +0100, kifayat ullah wrote:
> 
> 
> Hello All,
> 
> Please find the attached PATCH.
> 
> 
> 	* Target
> 	* M2TS files for BDMV ( blu-ray Disc)
> 	* Issue
> 	* M2TS files have AC3 audio stream was not not playing sounds on certain blu-ray players.
> 	* The tests has been performed on Software player like Power DVD 10,11 etc and Hardware Player like SONY Playstation.
> 	* Stream Analysis shows that audio stream packets (PID = 0x1100) are there is 
> M2TS audio stream, PTS were Same as of thier crossponding Video packets, so while testing on Directshow filtergraph there was no lip sync 
> issues.
> 
> 	* Audio Issue has been observe only when an ISO 
> composed of BDMV ( complete Folder Structure and Files) + Certificate is mounted and played as Blu-ray disc in PowerDVD and also when same ISO 
> burn on Blu-ray Disc and played using SONY Play Station.
> 
> 	* Fix
> 	* The New PATCH is submitted to fix above issue. In PATCH there is introduction of new value of 
> extension flags for AC3 Audio packets.
> 	* Tests
> 	* Test has been done on files (AVC+AC3, MPEG2Video+AC3) 
> 
> 	* Results shows that AC3 audio is now playing on all above mentions players.
> Kind Regards,
> Kifayat Ullah

>  mpegtsenc.c |   30 +++++++++++++++++++++++++++---
>  1 file changed, 27 insertions(+), 3 deletions(-)
> 93eee6b110378d50614ce4dc4879e635db2fd19f  mpegtsenc.patch
> From 7cf21025288c1c639cf1012e4ef99bac448a7fcf Mon Sep 17 00:00:00 2001
> From: Kifayat ullah <kifayat.ullah at fortiumtech.com>
> Date: Fri, 20 Jul 2012 10:30:04 +0100
> Subject: [PATCH 1/4] AC3 Sound issue in Blu-ray Palyers for m2ts has been
>  fixed.
> 
> ---
>  libavformat/mpegtsenc.c |   30 +++++++++++++++++++++++++++---
>  1 files changed, 27 insertions(+), 3 deletions(-)
> 
> diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c
> index aba266b..5773443 100644
> --- a/libavformat/mpegtsenc.c
> +++ b/libavformat/mpegtsenc.c
> @@ -916,11 +916,16 @@ static void mpegts_write_pes(AVFormatContext *s, AVStream *st,
>                      *q++ = 0xfd;
>                  } else
>                      *q++ = 0xe0;
> -            } else if (st->codec->codec_type == AVMEDIA_TYPE_AUDIO &&
> -                       (st->codec->codec_id == CODEC_ID_MP2 ||
> +            } else if (st->codec->codec_type == AVMEDIA_TYPE_AUDIO){
> +                       if(st->codec->codec_id == CODEC_ID_MP2 ||
>                          st->codec->codec_id == CODEC_ID_MP3 ||
> -                        st->codec->codec_id == CODEC_ID_AAC)) {
> +                        st->codec->codec_id == CODEC_ID_AAC) {
>                  *q++ = 0xc0;
> +                        }else if(ts->m2ts_mode && st->codec->codec_id == CODEC_ID_AC3) /** For AC3 Audio on Blu-ray value will be 0xfd*/
> +                        {
> +                        	*q++ = 0xfd;
> +                        }

indention depth in ffmpeg is 4 spaces, tabs are forbidden

also more importantly this changes behavior for audio streams that are
neither mp2/mp3/aac/ac3, is this intended?

[..]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120727/b341884f/attachment.asc>