[FFmpeg-devel] [PATCH] lavd/oss: support for more than 2 channels

[Paul B Mahol]

On 7/26/12, Nicolas George <nicolas.george at normalesup.org> wrote:
> Le sextidi 6 thermidor, an CCXX, Alexander Strasser a ecrit :
>> > +    if (s->channels > 2) {
>> > +        av_log(s1, AV_LOG_ERROR, "%d channels not yet supported.\n",
>> > s->channels);
>> > +        if (is_output)
>> > +            av_log(s1, AV_LOG_ERROR, "You can add the '-ac 2' option to
>> > let ffmpeg downmix to stereo.\n");
>> > +        return AVERROR_PATCHWELCOME;
>> > +    }
>>   While your patch seems sensible. I think this is not the right place
>> for the hint on command line usage. Not sure if it is easy to implement
>> the command line usage hint outside of lavd...
>
> I do not insist on it, but I believe it useful (I suspect the original
> patch
> was related to a confusion between the -channels and -ac options) and I
> really do not see any other way of implementing any other way. Considering
> that lavd is not used much, I believe the people who will actually see the
> warning are very likely to be using the ffmpeg command-line tool anyway.
>
> Is there anyone else who cares enough and wants to give an advice?

If you are not going to improve this code at all leave it.
There is no need to add messages, just leave code to rest in piece.