[FFmpeg-devel] [PATCH] mxfdec: fix off by one error in d10 aes3 decoding

[Matthieu Bouron]

On Thu, Jul 19, 2012 at 01:23:20AM +0200, Marton Balint wrote:
> Without this fix the last sample was missing from the packet.
> 
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  libavformat/mxfdec.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index a553eb5..b5eb1ad 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -322,7 +322,7 @@ static int mxf_get_d10_aes3_packet(AVIOContext *pb, AVStream *st, AVPacket *pkt,
>      data_ptr = pkt->data;
>      end_ptr = pkt->data + length;
>      buf_ptr = pkt->data + 4; /* skip SMPTE 331M header */
> -    for (; buf_ptr + st->codec->channels*4 < end_ptr; ) {
> +    for (; buf_ptr + st->codec->channels*4 <= end_ptr; ) {
>          for (i = 0; i < st->codec->channels; i++) {
>              uint32_t sample = bytestream_get_le32(&buf_ptr);
>              if (st->codec->bits_per_coded_sample == 24)

Looks good to me.
I also ran some test to check this patch and it seems good.

Regards,
Matthieu