[FFmpeg-devel] [PATCH 1/5] lavf: make cmdutils's check_stream_specifier public.

[Nicolas George]

Le tridi 3 thermidor, an CCXX, Stefano Sabatini a écrit :
> Reminder: minor bump + APIchanges entry.

Done.

> specififier -> specifier
> 
> Also maybe more clear:
> Check if the stream st contained in s is matched by the stream specifier spec.

Adopted.

> strem -> stream

Fixed.

> Note: I think that since this is going into the lib having it
> documented in avtools-common-opts.texi is not a good idea.
> 
> Also a "Stream specifiers" chapter really doesn't belong to a file
> named "common options", maybe doc/syntax.texi would be a better place.

I do not think it matters much, as long as it is properly cross-referenced
(with links). If you want to move things around, you are welcome, of course.
But it may cause merge conflicts.

> Also I don't know if we should document it in the lib doxy anyway (but
> don't consider this blocking, just maybe add a TODO or FIXME).

Duplicating things is evil.

I pushed the four approved patches, with the fixed version of the macros.

Thanks.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120720/f9069cfd/attachment.asc>