[FFmpeg-devel] [PATCH] avf:rmdec.c fill duration to AVFormatContext

[William Yu]

2012/7/13 William Yu <genwillyu at gmail.com>:
> 2012/7/13 Michael Niedermayer <michaelni at gmx.at>:
>> On Thu, Jul 12, 2012 at 10:36:51AM +0800, William Yu wrote:
>>> 2012/7/11 Michael Niedermayer <michaelni at gmx.at>:
>>> > On Wed, Jul 11, 2012 at 01:12:19PM +0800, William Yu wrote:
>>> >> 2012/7/6 Michael Niedermayer <michaelni at gmx.at>:
>>> >> > On Fri, Jul 06, 2012 at 12:29:15PM +0800, William Yu wrote:
>>> >> >> I think rmdec should fill duration to AVFormatContext so that ffprobe
>>> >> >> can check duration for rm file.
>>> >> >>
>>> >> >> ---
>>> >> >>  libavformat/rmdec.c | 3 ++-
>>> >> >>  1 file changed, 2 insertions(+), 1 deletion(-)
>>> >> >>
>>> >> >
>>> >> > isnt the MDPR parsing code enough to get this set already ?
>>> >> Sorry for my delay.
>>> >> I have a rm file. It only set duration in PROP. video and audio
>>> >> stream's duration in MDPR are zero.
>>> >> But MediaInfo can show this file's duration.
>>> >>
>>> The rm file has been upload to ftp://ftp.ffmpeg.org/incoming.
>>> The file name is zero_dur.rmvb
>>
>> ok, thanks
>>
>> AVFormatContext.duration should only be set if no AVStream duration
>> is&can be set. (see docs in avformat.h)
>> the patch should be ok if its changed accordingly
>
> patch is updated, Please check it again.

Ping. what about this patch? Need more changes?

>
>>
>> thanks
>>
>> [..]