[FFmpeg-devel] [PATCH 1/2] mxfenc: support smpte dv codec

[Tomas Härdin]

On Fri, 2012-06-29 at 22:09 +0200, Matthieu Bouron wrote:
>  libavformat/mxfenc.c | 138 +++++++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 135 insertions(+), 3 deletions(-)
> @@ -169,6 +171,51 @@ static const MXFContainerEssenceEntry mxf_essence_container_uls[] = {

I didn't noticed these actually have the DVCPRO HD ULs before, so I
suppose it's OK. I'm still not a fan of that unknown entry, but I
suppose SMPTE wouldn't reserve an UL for it if it wasn't important.

> +static int mxf_parse_dv_frame(AVFormatContext *s, AVStream *st, AVPacket *pkt)
> ...
> +    sc->interlaced = (vsc_pack[3] >> 4) & 0x01;
> +    // TODO: fix dv encoder to set proper FF/FS value in VSC pack
> +    // and set field dominance accordingly

Is there a ticket for adding this to the DV encoder/parser? Doesn't need
to be done right now since this code could be moved at a later time.

Looks fine otehrwise.

/Tomas