[FFmpeg-devel] [PATCH] Fallback to input timestamps for non-delay encoders.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Jan 29 11:24:53 CET 2012


On 29 Jan 2012, at 01:06, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sat, Jan 28, 2012 at 10:43:54PM +0100, Reimar Döffinger wrote:
>> Causes FFmpeg to pass through the correct pts values,
>> instead of clobbering all to AV_NOPTS_VALUE (the av_init_packet
>> default) to then make up new ones based on only fps when muxing.
>> Included are also the related FATE ref changes, which all
>> some reasonable on quick investigation.
>> Also set all H.264 references to us -vsync drop to reduce the
>> diff for the ref files.
>> Otherwise almost all H.264 references need to change, mostly due
>> to now starting with negative pts values.
>> About 20 additional H.264 conformance tests needed -vsync
>> drop anyway because they create pts values that are out of
>> order and thus not possible to mux otherwise.
> 
> should be ok if you tried the changed files with ffplay and they
> didnt get worse

Any chance someone else can test?
I probably can avoid it with some SDL environment variables hack, but ffplay currently just crashes X for me (I suspect some issue with XVideo with ATI drivers).

> also make sure this doesnt miss a chnage to teh seek regression test
> checksums

I ran the full make fate (actually I ran it lots of times also on the previous versions) and nothing else ever changed.
Part of the reason might be that the seektest files are all fixed frame rate, where this issue makes no difference.


More information about the ffmpeg-devel mailing list