[FFmpeg-devel] [PATCH 02/12] lavu: add public timecode API.

[Clément Bœsch]

On Wed, Jan 25, 2012 at 07:34:23PM +0100, Alexander Strasser wrote:
> Hi,
> 
> Clément Bœsch wrote:
> > On Tue, Jan 24, 2012 at 10:21:02PM +0100, Alexander Strasser wrote:
> > > Clément Bœsch wrote:
> > > > On Tue, Jan 24, 2012 at 01:47:30PM +0100, Stefano Sabatini wrote:
> > > > [...]
> > > > > > + * @note Frame number adjustment is automatically done in case of drop timecode,
> > > > > > + *       you do NOT have to call av_adjust_ntsc_framenum().
> > > > > 
> > > > > nit++: no complete sentence, lowcased and no dot at the end
> > > > > 
> > > > 
> > > > Most of the the @note I see are of two forms:
> > > > 
> > > >   @note frame number adjust is [...] ...framenum().
> > > >     ==> "note that xxxx."
> > > >   @note Frame number [...] ...framenum().
> > > >     ==> "NOTE: xxxx."
> > > > 
> > > > I used the second form, but it seems you do not want the first form
> > > > either. Should I just drop the period? The sentence still has verbs… Could
> > > > you be a bit more explicit about what you are expecting with an example?
> > > > 
> > > > [...]
> > > > > > + */
> > > > > > +uint32_t av_timecode_get_smpte_from_framenum(const AVTimecode *tc, int framenum);
> > > > > 
> > > > > Nit: get->make is maybe more approriate (as noted by Alexander
> > > > > Strasser in a recent mail)
> > > 
> > >   First of all thanks to Stefano for caring about naming. Second I appologize to
> > > you, Clément, as proper naming needs some discussion :(
> > > 
> > 
> > Proper naming for public is important, better overthink it first.
> 
>   I fear I have another one. Seems I am only causing you work :(
> 
>   But please don't do anything if you think I am not making sense here.
>  
>   I just saw it would be good to have the tc parameter as the first one,
> for all av_timecode_* functions that use (read/write) its state (I think
> all others don't have that param at all).
> 

So a read only context would likely have a higher priority than an output
in the parameters list priority? I don't mind much. I'll update the
patchset next week. Consider it done locally.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120126/c9a487a9/attachment.asc>