[FFmpeg-devel] [PATCH] lavu: introduce av_parse_ratio() and use it in ffmpeg and lavfi/aspect
Reimar.Doeffinger at gmx.de
Wed Jan 25 19:31:36 CET 2012
On Tue, Jan 24, 2012 at 11:46:57PM +0100, Stefano Sabatini wrote:
> On date Saturday 2012-01-21 15:24:23 +0100, Reimar Döffinger encoded:
> > On Sat, Jan 21, 2012 at 02:59:59PM +0100, Stefano Sabatini wrote:
> > > av_parse_ratio_l(AVRational *q, const char *str, int max, void *log_ctx, int log_level_off)
> > As long as you write out "log". Saving 2 characters is hardly worth the
> > obfuscation.
> The problem is that then it sounds "av_parse_ratio_log()" which reads
> as "parse the ratio log" why "_l" just denotes a variant of the
> function (like _e, _d, _s, used in other APIs).
Well, I'd say and just as much only acting as confusion instead of real
I mean it is getting a bit long, but what about _logged?
Or maybe giving the define instead the name av_parse_ratio_quiet?
None of those sound good enough to me that I'd be mad at you for
not changing it, but I'd really prefer something better than
a single letter that could really mean anything.
More information about the ffmpeg-devel