[FFmpeg-devel] FRAPS skip frame handling

[Reimar Döffinger]

On 23 Jan 2012, at 04:35, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Jan 23, 2012 at 04:13:07AM +0100, Michael Niedermayer wrote:
>> On Sun, Jan 22, 2012 at 05:07:18PM +0100, Reimar Döffinger wrote:
>>> On Sun, Jan 22, 2012 at 05:01:23PM +0100, Michael Niedermayer wrote:
>>>>> //XXX/FIXME this is a temporary hack until all encoders output pts
>>>>> and since it does not have enough information gets it wrong.
>>>>> The real WTF is that this hack is run without printing the slightest
>>>>> message. Would have saved me about an hour time if someone had
>>>>> simply made that hack say that the encoder is broken.
>>>> 
>>>> Is this a regression ?
>>> 
>>> I don't think so, see my other patch, fixing it will change insane
>>> amounts of FATE test results, so I don't think it has ever worked
>>> unless it was "smuggled in" at some point.
>> 
>> release/0.8 with your patch:
>> 
>> --- /home/michael/ffmpeg-git/ffmpeg/tests/ref/fate/fraps-v2 2012-01-12 23:23:32.653325524 +0100
>> +++ tests/data/fate/fraps-v2    2012-01-23 04:08:49.207999655 +0100
>> @@ -1,10 +1,5 @@
>> 0, 0, 1179648, 0x99f80436
>> -0, 3000, 1179648, 0x99f80436
>> -0, 6000, 1179648, 0x99f80436
>> -0, 9000, 1179648, 0x99f80436
>> -0, 12000, 1179648, 0x99f80436
>> -0, 15000, 1179648, 0xe8ae7a30
>> -0, 18000, 1179648, 0xe8ae7a30
>> -0, 21000, 1179648, 0xe8ae7a30
>> -0, 24000, 1179648, 0xe8ae7a30
>> -0, 27000, 1179648, 0xe8ae7a30
>> +0, 3000, 1179648, 0xe8ae7a30
>> +0, 6000, 1179648, 0xe8ae7a30
>> +0, 9000, 1179648, 0xe8ae7a30
>> +0, 12000, 1179648, 0xe8ae7a30
>> make: *** [fate-fraps-v2] Error 1
> 
> part of this difference is the varibale fps flag in framecrc

Right, without that it does not matter that pts values are clobbered since frames are duplicated instead.
However the precision is not good in all cases I think.