[FFmpeg-devel] [PATCH] Improve support for PGS subtitles.

[David Mitchell]

On Sun, Jan 22, 2012 at 10:27 AM, compn <tempn at twmi.rr.com> wrote:

> On Sun, 22 Jan 2012 10:06:40 -0800, David Mitchell wrote:
> >On Jan 22, 2012, at 9:27 AM, compn <tempn at twmi.rr.com> wrote:
> >
> >> On Sun, 22 Jan 2012 09:14:15 -0800, David Mitchell wrote:
> >>> On Jan 22, 2012, at 8:38 AM, compn <tempn at twmi.rr.com> wrote:
> >>>
> >>>> On Sun, 22 Jan 2012 08:27:55 -0800, David Mitchell wrote:
> >>>>> I submitted this patch a few days ago. The developer documentation
> states
> >>>>> that if some time passes with no response to a patch that I should
> send a
> >>>>> reminder. So I'm doing that :).
> >>>>>>
> >>>>>> I've tested the code with MKV files in VLC (a recent revision from
> >>>>>> their git repo) and with HandBrake (a version that I hacked up to
> >>>>>> use ffmpeg's PGS subtitle decoder).
> >>>>
> >>>> bonus points if you upload a sample pgs file that your patch fixes.
> >>>
> >>> Unfortunately, I don't have the rights to redistribute the files I
> used as a reference.
> >>
> >> can you tell us the filename? is it a file found on public torrent
> >> sites?
> >
> >I didn't download the files from the Internet, so I don't know where you
> might find similar material.
>
> ok, well in the usa , its legal to make copies of copyrighted material
> for research, interoperability and accessability. since ffmpeg
> researches formats, is the very definition of interoperability and
> makes accessible subtitles for the hearing impaired, you will be
> covered.
>
> there is also a direct 'non-profit' fair use in the copyright law
> itself. ffmpeg is non profit.
>
> more info: http://www.copyright.gov/fls/fl102.html
>
> so please upload a pgs subtitle so we may test your patch?
>
> you can see our samples repo is full of copyrighted clips for
> educational and research use.
>
> http://samples.ffmpeg.org
>
> we have some pgs subs already, but we need more samples.
> http://samples.ffmpeg.org/sub/PGS/
>
> and here is where we store some of our research on various formats:
> http://wiki.multimedia.cx/index.php?title=Main_Page
>
> well its not required, but having the sample will help us and other
> projects that ffmpeg shares files with, including videolan, mplayer,
> xine etc.
>
> -compn
>

I still don't feel entirely comfortable providing a sample, although any
film that has subtitles translating on-screen text while people are talking
is likely to use the features for which I've added support. Lots of anime
released in the US does this, such as *Full Metal Panic? Fumoffu* (in
particular, episode 1) and *Eden of the East* (episodes 2 and 5 are good
examples).


> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>