[FFmpeg-devel] FRAPS skip frame handling

[Michael Niedermayer]

On Sun, Jan 22, 2012 at 05:49:56PM +0100, Reimar Döffinger wrote:
> On Sun, Jan 22, 2012 at 05:21:52PM +0100, Michael Niedermayer wrote:
> > On Sun, Jan 22, 2012 at 05:07:18PM +0100, Reimar Döffinger wrote:
> > > On Sun, Jan 22, 2012 at 05:01:23PM +0100, Michael Niedermayer wrote:
> > > > > //XXX/FIXME this is a temporary hack until all encoders output pts
> > > > > and since it does not have enough information gets it wrong.
> > > > > The real WTF is that this hack is run without printing the slightest
> > > > > message. Would have saved me about an hour time if someone had
> > > > > simply made that hack say that the encoder is broken.
> > > > 
> > > > Is this a regression ?
> > > 
> > > I don't think so, see my other patch, fixing it will change insane
> > > amounts of FATE test results, so I don't think it has ever worked
> > > unless it was "smuggled in" at some point.
> > 
> > if its not a regression then maybe we should wait until after 0.10
> > with fixing it ?
> > iam a bit afraid that major changes to timestamp handling might break
> > things
> 
> I you intend to do the release soonish it doesn't really matter much.

yes i plan to do it soonish


> But otherwise I consider the fact that (despite it appearing otherwise)
> do not have any tests whatsoever concerning time stamps a very serious
> issue.

of course, but if its no regression (this should be checked not
assumed) then i think its better after the release

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120122/b2da96da/attachment.asc>