[FFmpeg-devel] [PATCH] libopenjpeg renamed copy functions, simplified copying procedure

[Carl Eugen Hoyos]

Michael Bradshaw <mbradshaw <at> sorensonmedia.com> writes:

> > > +        image->comps[compno].data[image_index] =
> > frame->data[0][frame_index];
> > > +        ++image_index;
> >
> > Please merge these two lines (imo).
> 
> Fixed.  See attached.

Thank you, patch applied!

> > >      for (x = 0; x < width; ++x) {
> > > -        image->comps[compno].data[y * width + x] = frame_ptr[y *
> > > (frame->linesize[compno] / 2) + x];
> > > +        image->comps[compno].data[image_index] = frame_ptr[frame_index];
> > > +        ++image_index;
> > > +        ++frame_index;
> >
> > Can memcpy() be used here?

(Fortunately I didn't write "Please use memcpy here".)

> I wish, but libopenjpeg's buffer type is int-based, whereas FFmpeg's is
> uint8-based (or uint16-based).

Thank you for explaining this!

Carl Eugen