[FFmpeg-devel] [PATCH] cmdutils: include type in filter list.

[Nicolas George]

Le decadi 30 nivôse, an CCXX, Stefano Sabatini a écrit :
> nit: get_media_type_char() (consistent with av_get_picture_type_char() for example)

Ok.

> Please split the get_media_type_letter() change from the opt_filters()
> change.

Ok.

> suggestion: at your discretion, desc and descp for showing the
> correlation between the two variables

Ok.

> This check can be moved upward, also it is too restrictive on the
> second run but this is just a nit (unrelevante from the practical POV,
> so do as you prefer).

At first glance, I fear it will be more complicated, for no practical gain.

> Looks fine otherwise.

Thanks. Here are the new patches. The next four days will be very busy for
me, so feel free to apply if you want.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120119/6417daad/attachment.asc>