[FFmpeg-devel] [PATCH] mxfdec: Add missing free.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Jan 16 19:38:31 CET 2012


On Mon, Jan 16, 2012 at 01:30:10PM +0100, Tomas Härdin wrote:
> On Sun, 2012-01-15 at 10:08 +0100, Reimar Döffinger wrote:
> > Should fix valgrind FATE.
> > 
> > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> > ---
> >  libavformat/mxfdec.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> > index 10512ef..ac871c3 100644
> > --- a/libavformat/mxfdec.c
> > +++ b/libavformat/mxfdec.c
> > @@ -1915,6 +1915,7 @@ static int mxf_read_close(AVFormatContext *s)
> >  
> >      for (i = 0; i < mxf->nb_index_tables; i++) {
> >          av_freep(&mxf->index_tables[i].segments);
> > +        av_freep(&mxf->index_tables[i].ptses);
> >          av_freep(&mxf->index_tables[i].fake_index);
> >      }
> >      av_freep(&mxf->index_tables);
> 
> Yikes! OK of course.
> Does fate-demux run with valgrind now? Didn't it before, or is it
> something that has to be done manually?

Only one single machine on fate.ffmpeg.org runs with FATE enabled.
You can look at its config to see how to set it up, though in principle
in the end you want to end up with something like
TARGET_EXEC=valgrind --error-exitcode=1 --malloc-fill=0x2a --track-origins=yes --leak-check=full --gen-suppressions=all --suppressions=suppression
in config.mak.
And you'll want it to run ffmpeg_g instead of ffmpeg (that might
actually make sense to change in general).
It would probably also make sense to just add a --enable-valgrind
switch that will set up everything.


More information about the ffmpeg-devel mailing list