[FFmpeg-devel] [PATCH] ffprobe: fix leak in show_packets()

Michael Niedermayer michaelni at gmx.at
Thu Jan 12 02:41:33 CET 2012


On Thu, Jan 12, 2012 at 12:39:35AM +0100, Stefano Sabatini wrote:
> Call av_free_packets() at each demuxing loop iteration, not only when
> decoding.
> 

> X-ColaCount: +10

missing volume unit

otherwise LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120112/4bd4aee3/attachment.asc>


More information about the ffmpeg-devel mailing list