[FFmpeg-devel] [PATCH] mxfdec: Always compute essence container lengths

Tomas Härdin tomas.hardin at codemill.se
Wed Jan 11 10:54:08 CET 2012


On Tue, 2012-01-10 at 20:28 +0100, Reimar Döffinger wrote:
> On Tue, Jan 10, 2012 at 04:07:14PM +0100, Tomas Härdin wrote:
> > From 747239149c40fbdadec26f1b17bab2c18516e0c2 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= <tomas.hardin at codemill.se>
> > Date: Tue, 10 Jan 2012 15:54:59 +0100
> > Subject: [PATCH] mxfdec: Always compute essence container lengths
> > 
> > While we don't need to do this for files that follow the OPAtom spec there are
> > some files like 2011_DCPTEST_24FPS.V.mxf that claim to be OPAtom but are clip-
> > wrapped.
> 
> Maybe you should detect this case somehow and print a warning then?

I can't think of a decent way to do this though. essence_length changes,
but that is the case for normal OPAtom files too... and now I realize
this patch breaks the size of the last packet, due to
mxf_essence_container_end() returning a larger value :\

I've also noticed this file has (*essence_container_ul)[15] == 0, which
isn't particularly good (it should be non-zero).

I'll have to ponder what to do for this file for a bit more.. This
solution is not OK.

/Tomas



More information about the ffmpeg-devel mailing list