[FFmpeg-devel] [PATCH] ffprobe: add compact option to JSON writer

Stefano Sabatini stefasab at gmail.com
Tue Jan 10 18:27:05 CET 2012


On date Monday 2012-01-09 22:27:36 +0100, Clément Bœsch encoded:
> On Mon, Jan 09, 2012 at 03:52:17PM +0100, Stefano Sabatini wrote:
> > In data Monday 2012-01-09 14:54:11 +0100, Nicolas George ha scritto:
> > > Le decadi 20 nivôse, an CCXX, Stefano Sabatini a écrit :
> > > > +If set to 1 specify if the output should be compact, that is each
> > > > +section is printed on a single line. Default value is 0.
> > > 
> > > Nice.
> > > 
> > > > +        if (!json->compact)
> > > > +            JSON_INDENT();
> > > 
> > > Maybe you could use a macro for that as a whole?
> > > 
> > > > +    if (!json->compact)
> > > > +        JSON_INDENT(); printf("}");
> > > >  }
> > > 
> > > This one is strange.
> > 
> > Updated with these and other minor cosmetic fixes.
> > 
> > I'll push it in a few days if I read no more comments.
> 

> We could have even more compact (less spaces, a few other places where \n
> could be droppped), but LGTM as it. You can push anytime.

This could be: json=c=2

Applied.
-- 
FFmpeg = Free Fierce Marvellous Powered Enigmatic God


More information about the ffmpeg-devel mailing list