[FFmpeg-devel] [PATCH] ffprobe: add compact option to JSON writer

[Stefano Sabatini]

In data Monday 2012-01-09 14:54:11 +0100, Nicolas George ha scritto:
> Le decadi 20 nivôse, an CCXX, Stefano Sabatini a écrit :
> > +If set to 1 specify if the output should be compact, that is each
> > +section is printed on a single line. Default value is 0.
> 
> Nice.
> 
> > +        if (!json->compact)
> > +            JSON_INDENT();
> 
> Maybe you could use a macro for that as a whole?
> 
> > +    if (!json->compact)
> > +        JSON_INDENT(); printf("}");
> >  }
> 
> This one is strange.

Updated with these and other minor cosmetic fixes.

I'll push it in a few days if I read no more comments.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ffprobe-add-compact-option-to-JSON-writer.patch
Type: text/x-diff
Size: 5551 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120109/a2b8118c/attachment.bin>