[FFmpeg-devel] [PATCH] ffprobe: print error in main() rather than in probe_file()

[Clément Bœsch]

On Fri, Jan 06, 2012 at 09:44:45PM +0100, Stefano Sabatini wrote:
[...]
> On the other hand I'm not so sure this is a good idea, possibly
> -show_error should be used *only* for reporting probing file errors
> (rather than - inconsistently - syntax errors), so this may be changed
> to:
> 
>        else {
>            ret = probe_file(wctx, input_filename);
>            if (ret < 0 && do_show_error)
>                show_error(wctx, ret);
>        }
> 

Indeed, I tend to agree with this; only the probing errors should be
printed in that section, the command mis-usage doesn't belong here (and
isn't helpful anyway for anything IMO). The documentation might be
clarified on that point BTW.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120106/82f3b01c/attachment.asc>