[FFmpeg-devel] [PATCH] y41p encoder and decoder

Paul B Mahol onemda at gmail.com
Mon Jan 2 00:18:57 CET 2012


On 1/1/12, Michael Niedermayer <michaelni at gmx.at> wrote:
[...]
>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>> index 1f47aee..7582d3e 100644
>> --- a/libavcodec/allcodecs.c
>> +++ b/libavcodec/allcodecs.c
>> @@ -85,6 +85,7 @@ void avcodec_register_all(void)
>>      REGISTER_DECODER (BINK, bink);
>>      REGISTER_ENCDEC  (BMP, bmp);
>>      REGISTER_DECODER (BMV_VIDEO, bmv_video);
>> +    REGISTER_ENCDEC  (Y41P, y41p);
>>      REGISTER_DECODER (C93, c93);
>
> nit: they are alphabetically ordered

Fixed.
>
>>      REGISTER_DECODER (CAVS, cavs);
>>      REGISTER_DECODER (CDGRAPHICS, cdgraphics);
>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>> index 690ea38..c306933 100644
>> --- a/libavcodec/avcodec.h
>> +++ b/libavcodec/avcodec.h
>> @@ -255,6 +255,7 @@ enum CodecID {
>>      CODEC_ID_VBLE,
>>      CODEC_ID_DXTORY,
>>      CODEC_ID_V410,
>> +    CODEC_ID_Y41P,
>>      CODEC_ID_UTVIDEO = 0x800,
>>      CODEC_ID_ESCAPE130  = MKBETAG('E','1','3','0'),
>
> please use MKBETAG('Y','4','1','P'), so we can keep ABI compatibility
> with forks that append different codecs there.
>

Fixed.
>
>>
>> diff --git a/libavcodec/version.h b/libavcodec/version.h
>> index 1a6e330..064da05 100644
>> --- a/libavcodec/version.h
>> +++ b/libavcodec/version.h
>> @@ -21,7 +21,7 @@
>>  #define AVCODEC_VERSION_H
>>
>>  #define LIBAVCODEC_VERSION_MAJOR 53
>> -#define LIBAVCODEC_VERSION_MINOR 49
>> +#define LIBAVCODEC_VERSION_MINOR 50
>>  #define LIBAVCODEC_VERSION_MICRO 101
>                                       ^
> when increasing minor, micro should be reset to the base (100)

Fixed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-y41p-encoder-and-decoder.patch
Type: application/octet-stream
Size: 11724 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120101/f78bd5ce/attachment.obj>


More information about the ffmpeg-devel mailing list