[FFmpeg-devel] [PATCH] y41p encoder and decoder

Michael Niedermayer michaelni at gmx.at
Sun Jan 1 15:10:03 CET 2012


On Sun, Jan 01, 2012 at 11:28:16AM +0000, Paul B Mahol wrote:
> On 12/31/11, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> > Paul B Mahol <onemda <at> gmail.com> writes:
> >
> >> y41p is a packed 12-bit 4:1:1 YUV format used by Brooktree.
> >
> > (Fixes issue 1123 / ticket 102)
> > Just two nits:
> >
> >> +    avctx->pix_fmt             = PIX_FMT_YUV411P;
> >
> >> +    avctx->bits_per_raw_sample = 12;
> >
> > Isn't 12 the default anyway?
> >
> > [...]
> >
> >> +    .long_name    = NULL_IF_CONFIG_SMALL("Uncompressed YUV 4:1:1
> >> 12-bit"),
> >
> > Imo, this should be "Uncompressed packed YUV 4:1:1"
> > (But please feel free to ignore)
> >
> > Is encoding odd widths allowed?
> 
> Mplayer with bt411 driver crashes when trying to play Y41P muxed in
> avi with ffmpeg. (Even if I use -vcodec copy).
> 
> Another issue is that frame(for the only sample we have) is apparently
> vertically flipped, this is related to
> http://roundup.libav.org/issue2395. (Will try mentioned hack).
> 

> So probably encoder should not do vertical flip, and decoder is busted
> until there is way to find out if biHeight is positive or negative.

See BottomUp in avidec.c, same could be implemented in avienc.c

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120101/559e63c6/attachment.asc>


More information about the ffmpeg-devel mailing list