[FFmpeg-devel] [PATCH]Read swr_convert return value

Michael Niedermayer michaelni at gmx.at
Mon Feb 27 23:10:35 CET 2012

On Mon, Feb 27, 2012 at 09:43:56PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> > > I have no use-case and the patch is not tested, but swr_convert
> > > returns negative values on OOM, and I suspect ffmpeg should
> > > terminate in that case.
> > > 
> > > Please review, Carl Eugen
> > 
> > LGTM if fate passes
> I only see the same failure as fate-i486-linux-gnu-gcc-4.4, 
> so patch applied.
> The reason for the patch was this mail at -user, 
> am I correct that -xerror simply cannot always work?
> http://thread.gmane.org/gmane.comp.video.ffmpeg.user/35745

i dont see why we couldnt make xerror to always work, but that would
be some work (and maintaince effort)

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120227/4f8e81d6/attachment.asc>

More information about the ffmpeg-devel mailing list