[FFmpeg-devel] [PATCH] libavfilter/libmpcodecs: add vf_pp from current mplayer svn

Michael Niedermayer michaelni at gmx.at
Sun Feb 26 19:39:19 CET 2012

On Sun, Feb 26, 2012 at 04:50:27PM +0100, Stefano Sabatini wrote:
> On date Sunday 2012-02-26 15:46:08 +0100, Michael Niedermayer encoded:
> > This will allow us to do regression tests on libpostproc.
> > 
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavfilter/Makefile            |    1 +
> >  libavfilter/libmpcodecs/vf_pp.c |  241 +++++++++++++++++++++++++++++++++++++++
> >  libavfilter/vf_mp.c             |    1 +
> >  3 files changed, 243 insertions(+), 0 deletions(-)
> >  create mode 100644 libavfilter/libmpcodecs/vf_pp.c
> Not against, usual considerations apply, that is that if we manage to
> get this into libavfilter (same output and no speed loss) we should
> drop it in favor of the native implementation.

absolutely, yes

> BTW what's your plan about the external libpostproc repo?

ATM my plan is to keep ffmpegs libpostproc & external in sync.
That way we can have the full set of FATE clients test it for free.
And thouse who want it seperate have it seperate.
that keeping in sync would need to be automated in case we have more
than an occasional patch and some rule like always commit to ffmpeg
and cherry pick to libpostproc instead of the othert way around should
keep it reasonable clean.

ill apply the patch in a moment ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120226/217b99cf/attachment.asc>

More information about the ffmpeg-devel mailing list