[FFmpeg-devel] [PATCH 2/2] doc/examples: add audio decoding/filtering example.

[Stefano Sabatini]

On date Wednesday 2012-02-22 13:01:30 +0100, Clément Bœsch encoded:
> On Wed, Feb 22, 2012 at 11:58:53AM +0200, Andrey Utkin wrote:
> > 2012/2/21 Clément Bœsch <ubitux at gmail.com>:
> > > On Tue, Feb 21, 2012 at 05:59:24PM +0200, Andrey Utkin wrote:
> > >> As i see, abuffersink_params in the asink_init is not being referenced
> > >> or so. Its contents are just read and copied to internal context.
> > >> I think we should use automatic allocation - for sake of simplicity,
> > >> to avoid API users think they must also allocate AVABufferSinkParams
> > >> on a heap (using special function) and pass the pointer.
> > >
> > > What do you propose to achieve the "automatic allocation"?
> > 
> > Allocation on stack.
> > 
> 

> I wouldn't mind a av_[a]buffersink_get_defaults_params() or something,
> but maybe Stefano wants to comment on this.

This would break in case of ABI changes. The size of the struct may
change, so an application may allocate on the stack a struct with the
wrong size if not compiled against a not updated library version,
that's why we require the call of a library function.
-- 
FFmpeg = Fierce and Fiendish Miracolous Puristic Ecumenical Ghost