[FFmpeg-devel] [PATCH] af_pan: remove dual double/int storage of gain.

Clément Bœsch ubitux at gmail.com
Wed Feb 22 09:20:32 CET 2012

On Mon, Feb 20, 2012 at 09:28:53PM +0100, Nicolas George wrote:
> libswresample takes care of that now.
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  libavfilter/af_pan.c |   32 +++++++++-----------------------
>  1 files changed, 9 insertions(+), 23 deletions(-)
> Another solution would be allocate it dynamically in init and free it in
> config_props. That would make init slightly more fragile, but spare 31k of
> memory for the most part of the time. What do you think about it?

I don't think the 31k on the heap are really an issue, but OTOH having a
dynamic allocation in the init may easier the use of the opaque arg:
ffmpeg -map_channel will may use of this filter; while we can certainly
build a string easily and init the filter with it, using the opaque
parameter might slightly simplifies things.

I don't have any strong opinion on that matter though. Patch looks ok (if
tested), and the dynamic allocation can be done later if necessary.


Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120222/82f065db/attachment.asc>

More information about the ffmpeg-devel mailing list