[FFmpeg-devel] [PATCH 2/2] af_pan: use libswr for rematrixing.

Clément Bœsch ubitux at gmail.com
Mon Feb 20 19:53:14 CET 2012

On Thu, Feb 16, 2012 at 01:11:59PM +0100, Nicolas George wrote:
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  libavfilter/af_pan.c |   71 +++++++++++++++++---------------------------------
>  1 files changed, 24 insertions(+), 47 deletions(-)
> There is quite a bit of cleanup necessary afterwards: not only reindent, but
> eliminate the double/int union, the indirect function call, etc. But that
> would be a nightmare of rebase conflicts to do it before the patch is in
> final shape.

The patch LGTM, and worked the tests I did, thank you.

You might want to update the documentation to remove the "number of output
channels" condition for remapping (it's common to everything in pan now,
let's just get rid of it).

Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120220/c45b79c2/attachment.asc>

More information about the ffmpeg-devel mailing list