[FFmpeg-devel] [PATCH] fate-valgrind.supp: Suppress uninitialized warnings for h264.
Reimar.Doeffinger at gmx.de
Fri Feb 17 16:40:12 CET 2012
On 17 Feb 2012, at 08:15, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Feb 17, 2012 at 07:20:33AM +0100, Reimar Döffinger wrote:
>> On 17 Feb 2012, at 05:11, Michael Niedermayer <michaelni at gmx.at> wrote:
>>> A prettier solution is welcome.
>> The subject is wrong.
>> It will suppress all uninitialized data warnings for any decoder ouput.
> all uninitialized data warnings of all correct decoder output,
> fate does check that the output is correct. And that on all platforms
It checks that it matches the reference. Particularly for H.264 (though admittedly only the time stamps are a real issue) I am not sure that is the same as being correct.
>> IMO that is very close to making that valgind fate instance useless.
> what do you suggest on how to get rid of the warnings.
Option 1) Fix the uninitialized data source
Option 2) Disable the affected tests for valgrind runs
Option 3) Add those suppressions only for the files with the issue
Option 4) Ignore them (might need some buildsystem fixes if it currently causes some tests not to be run - we added -k to avoid that issue but that is no longer working in all cases)
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> Awnsering whenever a program halts or runs forever is
> On a turing machine, in general impossible (turings halting problem).
> On any real computer, always possible as a real computer has a finite number
> of states N, and will either halt in less than N cycles or never halt.
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel