[FFmpeg-devel] [PATCH] lavfi/drawtext: remove reference to unused option fix_bounds
michaelni at gmx.at
Fri Feb 10 18:32:57 CET 2012
On Fri, Feb 10, 2012 at 01:24:09PM +0200, Andrey Utkin wrote:
> 2012/2/7 Michael Niedermayer <michaelni at gmx.at>:
> > this could break scripts that use this option
> I've added this feature to libav.org several days ago, and it got
> merged from libav to ffmpeg just on this Tuesday, i think there's no
> such scripts on earth that use this option.
> Please go ahead with patch, these changes added from libav.org don't
> make sense in ffmpeg.org version of drawtext. Otherwise it requires
> implementing actual bounds fixing here :)
i agree they dont make sense, but let me elaborate on what i meant
with "could break scripts", ive really worded this too terse.
Assume someone writes a script that needs fix_bounds=0.
In ffmpeg thats default
In libav that needs a fix_bounds=0 option.
If ffmpeg now has a fix_bounds option and sets this to 0 by default
then one can write a script that works with both drawtext filters. If
we remove the option then writing such script becomes tricky
Implementing fix_bounds=1 is not unwelcome nor would it be hard though
i wonder if theres any usecase for it ...
Real word wraping into the next line would be usefull though ...
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel