[FFmpeg-devel] what to do when a patch breaks regression test

Pavel Koshevoy pkoshevoy at gmail.com
Fri Feb 10 01:45:08 CET 2012


I am trying to solve an issue JW Player is having with TS fragments 
produced by httpsegmenter -- 

Essentially, JW Player can't handle fragments that do not start with a 
PAT/PMT packet.  Currently TS muxer outputs PAT/PMT periodically every 
40 packets.  What I did was to force it to output PAT/PMT on every video 
keyframe as well.  I think this change is justified because of this 
comment in mpegtsenc.c --  /* Arbitrary values, PAT/PMT could be written 
on key frames */.

Of course this breaks the TS muxer regression test:

TEST    lavf-swf
TEST    lavf-tga
TEST    lavf-tiff
TEST    lavf-ts
--- /Users/pkoshevoy/src/ffmpeg/tests/ref/lavf/ts       2012-02-09 
13:39:47.000000000 -0700
+++ tests/data/fate/lavf-ts     2012-02-09 17:29:41.000000000 -0700
@@ -1,3 +1,3 @@
-8f61dad7652abbab9e49fca274dabf30 *./tests/data/lavf/lavf.ts
+34f95a300355d474767b436430eba15b *./tests/data/lavf/lavf.ts
  406644 ./tests/data/lavf/lavf.ts
  ./tests/data/lavf/lavf.ts CRC=0x133216c1
Test lavf-ts failed. Look at tests/data/fate/lavf-ts.err for details.
make: *** [fate-lavf-ts] Error 1

What should I do now?  Do I need to update the test?  If yes -- how?  
Will my patch be accepted into master?

Thank you,
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: httpsegmenter_jwplayer_support.patch
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120209/ad9b99e7/attachment.ksh>

More information about the ffmpeg-devel mailing list