[FFmpeg-devel] [PATCH] vf_fspp: use LOCAL_MANGLE instead of MANGLE.

[Michael Niedermayer]

On Thu, Feb 09, 2012 at 09:05:43PM +0100, Reimar Döffinger wrote:
> On Wed, Feb 08, 2012 at 11:22:01PM +0100, Clément Bœsch wrote:
> > On Wed, Feb 08, 2012 at 07:48:51PM +0100, Clément Bœsch wrote:
> > > On Tue, Feb 07, 2012 at 07:18:09PM +0100, Clément Bœsch wrote:
> > > > On Mon, Feb 06, 2012 at 07:23:40PM +0100, Clément Bœsch wrote:
> > > > > The symbols are locals, thus the EXTERN_PREFIX should be omitted. This
> > > > > might fix the llvm-gcc fate instance.
> > > > > ---
> > > > > I hope I'm not wrong here, but using MANGLE here doesn't sound right to me and
> > > > > it still works here locally. Also, I can not test on a Darwin machine, so any
> > > > > Mac user is welcome to test.
> > > > > ---
> > > > >  libavfilter/libmpcodecs/vf_fspp.c |   80 ++++++++++++++++++-------------------
> > > > >  1 files changed, 39 insertions(+), 41 deletions(-)
> > > > > 
> > > > > diff --git a/libavfilter/libmpcodecs/vf_fspp.c b/libavfilter/libmpcodecs/vf_fspp.c
> > > > [...]
> > > > 
> > > > I will commit this in a day or two if I see no comment, and will revert
> > > > ASAP if fate goes red.
> > > > 
> > > 
> > > Pushed. Wait & see.
> > > 
> > 
> > Reverted. Any suggestion on why this does fail is welcome.
> 
> LOCAL_MANGLE is for symbols also declared inside __asm__, not "local" as
> in the same file.
> I'd suspect that that compiler version just completely optimizes those
> variables away, so you have to use the same hack as for Intel of
> removing the "static" (though that might just cause symbol collisions
> instead, not sure).

if thats the issue, marking them as volatile or accessing them from
C that cannot be optimized away or having a seperate empty asm() that
reads them should work too

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120209/cf5ce283/attachment.asc>