[FFmpeg-devel] [PATCH] ffprobe: report audio bit rate in stream description

[Stefano Sabatini]

On date Tuesday 2012-02-07 10:44:22 +0100, Matthieu Bouron encoded:
> 2012/2/6 Clément Bœsch <ubitux at gmail.com>:
[...]
> From ab616ceea409f623b3d0c16bef714bba8036b96c Mon Sep 17 00:00:00 2001
> From: Matthieu Bouron <matthieu.bouron at smartjog.com>
> Date: Mon, 6 Feb 2012 17:07:18 +0100
> Subject: [PATCH 1/2] libavcodec: add avcodec_get_bit_rate function
> 
> ---
>  libavcodec/avcodec.h |    8 ++++++++
>  libavcodec/utils.c   |    4 ++--
>  libavcodec/version.h |    4 ++--
>  3 files changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 43c2128..bdd36b2 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -3512,6 +3512,14 @@ AVCodec *avcodec_find_decoder_by_name(const char *name);
>  void avcodec_string(char *buf, int buf_size, AVCodecContext *enc, int encode);
>  
>  /**
> + * Return the codec average bit rate

nit: missing dot

> + *
> + * @param codec the codec context

> + * @return the codec average bit rate

What happens if the information is not available in the codec? (I
suppose it will return 0 in this case, so you may need to extend the
docs for that or the user will get surprised).

Looks fine otherwise, but I'd like to hear the opinion from Michael
about this new interface.
-- 
FFmpeg = Friendly and Fundamentalist Magical Philosofic Evil Gorilla