[FFmpeg-devel] [PATCH] Fix potential infinite discard loop.

[Michael Niedermayer]

On Mon, Feb 06, 2012 at 09:16:42PM +0100, Reimar Döffinger wrote:
> On Sun, Feb 05, 2012 at 03:56:51PM +0100, Reimar Döffinger wrote:
> > On Sun, Feb 05, 2012 at 03:40:33PM +0100, Michael Niedermayer wrote:
> > > On Sun, Feb 05, 2012 at 03:36:21PM +0100, Reimar Döffinger wrote:
> > > > On Sun, Feb 05, 2012 at 03:11:25PM +0100, Reimar Döffinger wrote:
> > > > > The alternative is to make read_timestamps parse every single
> > > > > packet manually and just ignore what the demuxer claims it to
> > > > > be (though with printing a big fat warning every time it's wrong).
> > > > 
> > > > As in attached, but only for theora.
> > > > I guess you can imagine what kind of mess that becomes if you have
> > > > to add such a piece of code for every single codec know to man.
> > > 
> > > we only need to for every single video codec known to ogg, which
> > > should be quite a bit less.
> > > Besides anyone knows how the official libogg handles this ? Does it
> > > fail or parse too ?
> > 
> > It just seems to fail, at least MPlayer with -demuxer ogg shows the same
> > broken seeking behaviour as -demuxer lavf without the patch.
> > Though behaviour might differ with latest libogg since I think the files
> > contain an index, which probably contains correct information.
> 
> So do you think I should apply this patch?

if it fixes something and breaks nothing then iam certainly in favor

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120206/7d5e0a75/attachment.asc>