[FFmpeg-devel] [PATCH] Fix potential infinite discard loop.

[Reimar Döffinger]

On Sun, Feb 05, 2012 at 03:40:33PM +0100, Michael Niedermayer wrote:
> On Sun, Feb 05, 2012 at 03:36:21PM +0100, Reimar Döffinger wrote:
> > On Sun, Feb 05, 2012 at 03:11:25PM +0100, Reimar Döffinger wrote:
> > > The alternative is to make read_timestamps parse every single
> > > packet manually and just ignore what the demuxer claims it to
> > > be (though with printing a big fat warning every time it's wrong).
> > 
> > As in attached, but only for theora.
> > I guess you can imagine what kind of mess that becomes if you have
> > to add such a piece of code for every single codec know to man.
> 
> we only need to for every single video codec known to ogg, which
> should be quite a bit less.
> Besides anyone knows how the official libogg handles this ? Does it
> fail or parse too ?

It just seems to fail, at least MPlayer with -demuxer ogg shows the same
broken seeking behaviour as -demuxer lavf without the patch.
Though behaviour might differ with latest libogg since I think the files
contain an index, which probably contains correct information.