[FFmpeg-devel] [PATCH] oggdec: add missing ogg_reset on seek.
donmoir at comcast.net
Sat Feb 4 23:58:48 CET 2012
On Sat, Feb 04, 2012 at 09:05:33PM +0100, Reimar Döffinger wrote:
>> It would never be called when the searched-for position
>> was already in the index.
>> In the other cases, the ogg_reset at the end of the
>> read_timestamp function handled it.
>> Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> makes sense & LGTM
Keep in mind I also mentioned in ticket #941 that ogg_reset may not be
enough. You will still get whatever is in os->lastpts and os->lastdts in the
first packet read. ogg_reset replaces these with AV_NOPTS_VALUE and thats
better than gettting whatever was in the last packet read. But I believe
these values should be set to the correct values for the next packet read.
At least you can deal with it when they contain AV_NOPTS_VALUE but this is
still not correct.
More information about the ffmpeg-devel