[FFmpeg-devel] [PATCH] Fix potential infinite discard loop.

[Reimar Döffinger]

On Sat, Feb 04, 2012 at 02:27:32PM -0500, Don Moir wrote:
> 2) make sure os->keyframe_seek is set back to 0 always and don't depend on any return value. Currently this only set back to 0 only if the return value from 
> ff_seek_frame_binary is < 0. This is not correct. This fixed all the remaining weirdness.

That is wrong, os->keyframe_seek must stay 1 when we want to seek to a
keyframe, otherwise the code that checks it in ogg_read_packet becomes
dead code.
I don't know 100% sure that that code in ogg_read_packet is necessary,
though I would suspect so when a non-keyframe and then a keyframe are
packed together into a single ogg packet.

> 3) call ogg_reset after the seek - this is not perfect and there is something more with this but without this - the first packet read will contain stale information as mentioned above. You will still get AV_NOPTS_VALUE on the first read which is not right either. I think calling ogg_reset and setting the lastpts and lastdts in the ogg_stream may do it.

ogg_read_timestamp calls ogg_reset, thus this _should_ not be necessary.

> Since it appears items 2 and 3 were not addressed, I don't understand why ticket #941 was closed.

The main issue (seeking in itself) was fixed and worked fine for me.
If there are further issues it is best to open one ticket per issue.