[FFmpeg-devel] [PATCH] Fix potential infinite discard loop.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Feb 4 19:40:31 CET 2012

On Sat, Feb 04, 2012 at 07:02:34PM +0100, Michael Niedermayer wrote:
> On Sat, Feb 04, 2012 at 03:29:58PM +0100, Reimar Döffinger wrote:
> > Fixes trac issue #438.
> > Seeking in that sample would cause ogg_read_timestamp to fail
> > because ogg_packet would go into a state where all packets
> > of stream 1 would be discarded until the end of the stream.
> > 
> > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> if it works and considering you know the ogg demxuer better than me
> Id say patch is very likely correct

Nobody really knows it very well unfortunately.
For now I just go with the strategy of adding lots of comments,
hopefully that at least means we can avoid breaking it in the same
way multiple times.
I pushed it but only afterwards realized a big mess-up:
the issue it fixes is #941, so I added a comment to #438 to
clear that up.

More information about the ffmpeg-devel mailing list