[FFmpeg-devel] [PATCH] Fix png decoding on x86.

Michael Niedermayer michaelni at gmx.at
Fri Feb 3 22:36:46 CET 2012

On Fri, Feb 03, 2012 at 09:26:41PM +0100, Reimar Döffinger wrote:
> Line sizes are only 8-byte aligned, so use unaliged loads
> for add_bytes_l2 pointers.
> Increasing the alignment requirement to 16 seemed a bit extreme
> (png may be used for rather small sizes).
> Also fix a mov that had its arguments swapped, leading
> add_bytes_l2 being applied on up to 8 bytes too few.
> Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>

LGTM, thanks!

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120203/3a57b5b8/attachment.asc>

More information about the ffmpeg-devel mailing list