[FFmpeg-devel] [PATCH] Add comment about swresample buffering.
michaelni at gmx.at
Fri Feb 3 22:23:39 CET 2012
On Fri, Feb 03, 2012 at 09:15:12PM +0100, Reimar Döffinger wrote:
> On Fri, Feb 03, 2012 at 08:55:02PM +0100, Michael Niedermayer wrote:
> > On Fri, Feb 03, 2012 at 08:43:00PM +0100, Reimar Döffinger wrote:
> > > ---
> > > libswresample/swresample.h | 2 ++
> > > 1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/libswresample/swresample.h b/libswresample/swresample.h
> > > index 8dc4e1f..7651a83 100644
> > > --- a/libswresample/swresample.h
> > > +++ b/libswresample/swresample.h
> > > @@ -102,6 +102,8 @@ void swr_free(struct SwrContext **s);
> > > *
> > > * @param s allocated Swr context, with parameters set
> > > * @param out output buffers, only the first one need be set in case of packed audio
> > > + * Note: in case this is not sufficiently large, remaining
> > > + * samples will be buffered.
> > > * @param out_count amount of space available for output in samples per channel
> > > * @param in input buffers, only the first one need to be set in case of packed audio
> > > * @param in_count number of input samples available in one channel
> > this is only true when resampling is used
> What happens when resampling is not used? Will they be lost?
it returns an error
> Also, a suggestion was an API extension to get the number of buffered
> samples, does that sound useful?
sure, also it might be usefull (dunno maybe also not) to allow
buffering without resample. at least it would be more consitent.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel